Skip to content

feat: marketing to months feature flag#5542

Merged
emilyjablonski merged 12 commits into
mainfrom
5482/marketing-to-months
Nov 12, 2025
Merged

feat: marketing to months feature flag#5542
emilyjablonski merged 12 commits into
mainfrom
5482/marketing-to-months

Conversation

@emilyjablonski

@emilyjablonski emilyjablonski commented Nov 4, 2025

Copy link
Copy Markdown
Collaborator

This PR addresses #5482

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Creates a feature flag that allows marketing to use months instead of seasons.

How Can This Be Tested/Reviewed?

Partners:
Locally when creating a listing in Angelopolis, ensure that the under construction dropdown is using months, that you can save those values and see them on the detail page.

Public:
The month-based date should be visible on the directory page and the detail page in the under construction section, and the month strings should translate.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@netlify

netlify Bot commented Nov 4, 2025

Copy link
Copy Markdown

Deploy Preview for bloom-lakeview ready!

Name Link
🔨 Latest commit 6f009d0
🔍 Latest deploy log https://app.netlify.com/projects/bloom-lakeview/deploys/6914c74e7b5fd500089a7c56
😎 Deploy Preview https://deploy-preview-5542--bloom-lakeview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Nov 4, 2025

Copy link
Copy Markdown

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit 6f009d0
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/6914c74e4164da0008c556fe
😎 Deploy Preview https://deploy-preview-5542--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Nov 4, 2025

Copy link
Copy Markdown

Deploy Preview for bloom-flagly ready!

Name Link
🔨 Latest commit 6f009d0
🔍 Latest deploy log https://app.netlify.com/projects/bloom-flagly/deploys/6914c74e0a509900088e271a
😎 Deploy Preview https://deploy-preview-5542--bloom-flagly.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Nov 4, 2025

Copy link
Copy Markdown

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit 6f009d0
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/6914c74e7c99de00088edd71
😎 Deploy Preview https://deploy-preview-5542--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Nov 4, 2025

Copy link
Copy Markdown

Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit 6f009d0
🔍 Latest deploy log https://app.netlify.com/projects/bloom-public-seeds/deploys/6914c74e4b52c000083e0624
😎 Deploy Preview https://deploy-preview-5542--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@emilyjablonski emilyjablonski marked this pull request as ready for review November 5, 2025 00:57
@emilyjablonski emilyjablonski added the 1 review needed Requires 1 more review before ready to merge label Nov 5, 2025
@netlify

netlify Bot commented Nov 6, 2025

Copy link
Copy Markdown

Deploy Preview for bloom-angelopolis ready!

Name Link
🔨 Latest commit 6f009d0
🔍 Latest deploy log https://app.netlify.com/projects/bloom-angelopolis/deploys/6914c74e94f9350008d28151
😎 Deploy Preview https://deploy-preview-5542--bloom-angelopolis.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@emilyjablonski emilyjablonski force-pushed the 5482/marketing-to-months branch from 2c1661d to 42ff94d Compare November 6, 2025 16:53
Comment thread .prettierignore Outdated
@ludtkemorgan ludtkemorgan added the needs changes The author must make changes and then re-request review before merging label Nov 7, 2025
@emilyjablonski emilyjablonski removed the needs changes The author must make changes and then re-request review before merging label Nov 10, 2025

@ludtkemorgan ludtkemorgan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the tests! Just one question, depending on the answer it's good to merge and if it was an oversight the fix should be simple so approving it for merge!

Comment thread sites/public/src/lib/helpers.tsx Outdated
@ludtkemorgan ludtkemorgan added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Nov 11, 2025
@emilyjablonski emilyjablonski merged commit 4414cdf into main Nov 12, 2025
34 of 35 checks passed
@emilyjablonski emilyjablonski deleted the 5482/marketing-to-months branch November 12, 2025 19:12
mcgarrye pushed a commit to metrotranscom/doorway that referenced this pull request Nov 19, 2025
ludtkemorgan pushed a commit to metrotranscom/doorway that referenced this pull request Nov 24, 2025
ludtkemorgan pushed a commit to metrotranscom/doorway that referenced this pull request Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Should be applied when a PR has been reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants